DOC DB read-only replicas #587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emteknetnz
force-pushed
the
pulls/5/db-replica
branch
from
114703d
to
8ff5036
Compare
emteknetnz
force-pushed
the
pulls/5/db-replica
branch
4 times, most recently
from
07d3b24
to
3e95db2
Compare
GuySartorelli
requested changes
Sep 23, 2024
en/02_Developer_Guides/08_Performance/07_DB_read_only_replicas.md
Outdated
Show resolved
Hide resolved
en/02_Developer_Guides/08_Performance/07_DB_read_only_replicas.md
Outdated
Show resolved
Hide resolved
en/02_Developer_Guides/08_Performance/07_DB_read_only_replicas.md
Outdated
Show resolved
Hide resolved
en/02_Developer_Guides/08_Performance/07_DB_read_only_replicas.md
Outdated
Show resolved
Hide resolved
en/02_Developer_Guides/08_Performance/07_DB_read_only_replicas.md
Outdated
Show resolved
Hide resolved
en/02_Developer_Guides/08_Performance/07_DB_read_only_replicas.md
Outdated
Show resolved
Hide resolved
en/02_Developer_Guides/08_Performance/07_DB_read_only_replicas.md
Outdated
Show resolved
Hide resolved
en/02_Developer_Guides/08_Performance/07_DB_read_only_replicas.md
Outdated
Show resolved
Hide resolved
GuySartorelli
requested changes
Sep 24, 2024
en/02_Developer_Guides/08_Performance/07_DB_read_only_replicas.md
Outdated
Show resolved
Hide resolved
emteknetnz
force-pushed
the
pulls/5/db-replica
branch
6 times, most recently
from
45647f1
to
adb66c3
Compare
en/02_Developer_Guides/08_Performance/07_DB_read_only_replicas.md
Outdated
Show resolved
Hide resolved
GuySartorelli
requested changes
Sep 26, 2024
en/02_Developer_Guides/08_Performance/07_Read_only_database_replicas.md
Outdated
Show resolved
Hide resolved
emteknetnz
force-pushed
the
pulls/5/db-replica
branch
from
adb66c3
to
9930e9c
Compare
GuySartorelli
requested changes
Sep 26, 2024
There was a problem hiding this comment.
- DOC DB read-only replicas #587 (comment) still needs to be done
- Added comment to DOC DB read-only replicas #587 (comment) (sorry, forgot to start review)
emteknetnz
force-pushed
the
pulls/5/db-replica
branch
2 times, most recently
from
e98eeb8
to
b286048
Compare
emteknetnz
force-pushed
the
pulls/5/db-replica
branch
4 times, most recently
from
c06669d
to
5ac7832
Compare
GuySartorelli
approved these changes
Oct 8, 2024
GuySartorelli
requested changes
Oct 10, 2024
en/08_Changelogs/6.0.0.md
Outdated
|
|
||
| See [read-only database replicas](/developer_guides/performance/read_only_database_replicas/) for more details. | ||
|
|
||
| Calling the methods [`DB::get_conn()`](api:SilverStripe\ORM\DB::get_conn()), [`DB::set_conn()`](api:SilverStripe\ORM\DB::set_conn()), [`DB::getConfig()`](api:SilverStripe\ORM\DB::getConfig()), and [`DB::setConfig()`](api:SilverStripe\ORM\DB::setConfig()) using the default `$name` parameter of "default" will now emit a deprecation notice and will be internall converted to "primary". Pass [`DB::CONN_PRIMARY`](api:SilverStripe\ORM\DB::CONN_PRIMARY) or simply "primary" for the `$name` parameter instead. The default value for `$name` will be changed to "primary" in a future major release. |
There was a problem hiding this comment.
No deprecation notice - looks like these docs may not have been updated to reflect that it's now CMS 6? Don't know how I missed that before.
There was a problem hiding this comment.
Updated, have changed to mention that "default" has changed to "primary"
emteknetnz
force-pushed
the
pulls/5/db-replica
branch
from
5ac7832
to
5a76f07
Compare
|
Linting issue is unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue silverstripe/silverstripe-framework#11352