API Convert SecurityAdmin to be a ModelAdmin #1359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
emteknetnz
force-pushed
the
pulls/2/security-admin-ii
branch
3 times, most recently
from
1025700
to
40f1124
Compare
emteknetnz
commented
Sep 7, 2022
emteknetnz
commented
Sep 7, 2022
|
Unit tests failing because symfony 6 PRs need to be merged. Re-run tests after that |
GuySartorelli
requested changes
Sep 8, 2022
There was a problem hiding this comment.
It feels a bit suspect that there's no javascript or css being removed - is there really no double-up of javascript or css for the old SecurityAdmin that is now handled by existing ModelAdmin javascript? E.g. inside client/src/legacy/SecurityAdmin.js or client/src/styles/legacy/_SecurityAdmin.scss?
emteknetnz
force-pushed
the
pulls/2/security-admin-ii
branch
4 times, most recently
from
b79bdea
to
b669289
Compare
GuySartorelli
requested changes
Sep 15, 2022
emteknetnz
force-pushed
the
pulls/2/security-admin-ii
branch
from
b669289
to
9ba43b6
Compare
Co-authored-by: Maxime Rainville <[email protected]>
emteknetnz
force-pushed
the
pulls/2/security-admin-ii
branch
from
9ba43b6
to
48108c1
Compare
GuySartorelli
approved these changes
Sep 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #1350
Continued from where Max got to with #963 - I've included him as a co-author in the commit message