Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX Support nested redux forms #1694

Conversation

GuySartorelli
Copy link
Member

@GuySartorelli GuySartorelli commented Feb 26, 2024

Description

Allows nested redux-forms to be submitted without propogating the nested submit event up to the parent form.

Manual testing steps

  1. Add the associated PRs (see issue) to your site
  2. Upload a file to your site
  3. Set up an elemental block that has links (single or multi doesn't matter)
  4. Add a file link
  5. Select "choose existing" and then select the file
  6. Make sure your browser window width is less than 992px wide (the "insert" button when you've selected the file should become "insert file")
  7. Click "insert file" (this should add the file to the upload field and NOT submit the link form)
  8. Save the link (this should not give you a console warning about not returning a promise)

Issues

Pull request checklist

  • The target branch is correct
  • All commits are relevant to the purpose of the PR (e.g. no debug statements, unrelated refactoring, or arbitrary linting)
    • Small amounts of additional linting are usually okay, but if it makes it hard to concentrate on the relevant changes, ask for the unrelated changes to be reverted, and submitted as a separate PR.
  • The commit messages follow our commit message guidelines
  • The PR follows our contribution guidelines
  • Code changes follow our coding conventions
  • CI is green

Copy link
Contributor

@sabina-talipova sabina-talipova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested locally.

@sabina-talipova sabina-talipova merged commit 0c5de61 into silverstripe:2 Mar 1, 2024
12 checks passed
@sabina-talipova sabina-talipova deleted the pulls/2/support-nested-forms branch March 1, 2024 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants