Apply suggestions from code review

Co-authored-by: Steve Boyd <[email protected]>
silverstripe · Mar 23, 2022 · 9594659 · 9594659
1 parent 9677235
commit 9594659
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/client/src/components/ElementActions/tests/SaveAction-test.js b/client/src/components/ElementActions/tests/SaveAction-test.js
@@ -14,7 +14,7 @@ describe('SaveAction', () => {
   const WrappedComponent = (props) => <div>{props.children}</div>;
   const ActionComponent = SaveAction(WrappedComponent);
 
-  it('renders a button when block is expendable', () => {
+  it('renders a button when block is expandable', () => {
     wrapper = mount(
       <ActionComponent
         title="My save action"
@@ -31,7 +31,7 @@ describe('SaveAction', () => {
     expect(wrapper.find('button').length).toBe(1);
   });
 
-  it('does not renders a button when block is not expendable', () => {
+  it('does not renders a button when block is not expandable', () => {
     wrapper = mount(
       <ActionComponent
         title="My save action"

diff --git a/client/src/components/ElementEditor/ElementActions.js b/client/src/components/ElementEditor/ElementActions.js
@@ -74,7 +74,7 @@ class ElementActions extends Component {
    * @returns {ActionMenuComponent|null}
    */
   render() {
-    const { children, id, ActionMenuComponent, expandable } = this.props;
+    const { children, id, ActionMenuComponent } = this.props;
 
 
     const dropdownToggleClassNames = [

diff --git a/client/src/components/ElementEditor/tests/ElementActions-test.js b/client/src/components/ElementEditor/tests/ElementActions-test.js
@@ -75,7 +75,7 @@ describe('ElementActions', () => {
       expect(wrapper.find('DropdownItem').length).toBe(1);
     });
 
-    it('should not render tab for none-expandable block', () => {
+    it('should not render inline-edit items for non-expandable block', () => {
       const wrapper = shallow(
         <ElementActions
           areaId={1}