Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT Replace sass-lint with stylelint #1173

Merged

Conversation

sabina-talipova
Copy link
Contributor

@sabina-talipova sabina-talipova commented Apr 22, 2024

Description

Stylelint has about 100 rules, which are turned on by default (See).
This PR removed support of old sass-lint and implemented new stylelint. New file .stylelintrc.yml add some configuration for default rules and also turn off some rules that we doesn't support. Probably they required additional review.

Issues

@sabina-talipova sabina-talipova marked this pull request as ready for review April 22, 2024 23:39
@sabina-talipova sabina-talipova force-pushed the pulls/5.2/stylelint branch 2 times, most recently from 6f3be4e to 2aee588 Compare April 25, 2024 20:30
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GuySartorelli GuySartorelli merged commit edd4808 into silverstripe:5.2 Apr 28, 2024
13 checks passed
@GuySartorelli GuySartorelli deleted the pulls/5.2/stylelint branch April 28, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants