NEW: Better type default.

[mfendeksilverstripe]

Better type default for BaseElement

• better default for the Type on BaseElement
• simplified configuration (configured by singular_name)
• localisation is retained

Related issues

#831

[ScopeyNZ]

Thanks for the PR @mfendeksilverstripe. You'll need to target 4 for this change as it's an enhancement.

I believe that we didn't use i18n_singular_name here on purpose, but I can't remember why... Maybe Robbie will be able to shed some light.

[mfendeksilverstripe]

@ScopeyNZ Rebased on 4.

[brynwhyman]

I believe that we didn't use i18n_singular_name here on purpose, but I can't remember why... Maybe Robbie will be able to shed some light.

People might avoid this PR due to this comment. Let's see if @robbieaverill remembers ;P

[emteknetnz]

I've made a recommended change - would this work for you?

[mfendeksilverstripe]

This is ready for review @emteknetnz

[emteknetnz]

Looking through previous comments + code I think the reason not to use i18n_singular_name was because if no translation yml or config defines singlular name, it will back to ClassInfo::shortName($this) which is the classname minus the namespace. Depending on the name of the class, that may be worse reading than simply "Block"

However i18n_singular_name is used a lot throughout Silverstripe, so I'm happy as is

@mfendeksilverstripe there's a PHPCS issue to fix before merging https://app.travis-ci.com/github/silverstripe/silverstripe-elemental/jobs/544323711#L1298

[mfendeksilverstripe]

@emteknetnz Thanks for feedback, I've pushed up the linting fix.

[emteknetnz]

Travis failure in PHP8 behat is existing