Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEP Update eslint-config #962

Merged
merged 1 commit into from
Mar 25, 2022

Conversation

emteknetnz
Copy link
Member

Copy link
Contributor

@maxime-rainville maxime-rainville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pulled this PR down and ran a yarn build. The yarn.lock file was updated to reflect the new devDependency.

How come the yarn.lock file hasn't been updated? And why isn't the Travis build failing ... it's meant to detect this kind of oversight?

@emteknetnz
Copy link
Member Author

emteknetnz commented Mar 11, 2022

We're not updating deps here (updating yarn.lock). What we're doing is making it so the next time yarn upgrade is run, it will get the latest version of eslint-config 0.1.x

There's no material difference between eslint-config 0.0.6 and 0.1.0. The only different is that if we release 0.1.1, the ^ caret now means that asset-admin etc will get 0.1.1. Previously with ^0.0.6 the caret effectively did nothing.

@emteknetnz
Copy link
Member Author

Have updated PR after running yarn install

@maxime-rainville maxime-rainville merged commit 3fe3c41 into silverstripe:4 Mar 25, 2022
@maxime-rainville maxime-rainville deleted the pulls/4/eslint branch March 25, 2022 02:49
menno-rdmkr pushed a commit to busting-bytes/silverstripe-elemental that referenced this pull request Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants