Use public/_graphql/ subfolder #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is consistent with public/_resources which is also auto-generated by the CMS. It enables sysadmins to lock down write access to public/ during runtime, with this potentially granular exception. And it makes it easier to discover which part of the system is responsible for writing these files. The change is backwards compatible with existing file locations, although we probably want to remove that before going stable: silverstripe#384 Relies on equivalent PR to silverstripe/admin. The docs are already stating this new location so this was more of an oversight: https://docs.silverstripe.org/en/4/developer_guides/graphql/getting_started/building_the_schema/#viewing-the-generated-code
chillu
added a commit
to open-sausages/silverstripe-admin
that referenced
this pull request
Jun 1, 2021
chillu
added a commit
to open-sausages/silverstripe-admin
that referenced
this pull request
Jun 1, 2021
unclecheese
approved these changes
Nov 4, 2021
unclecheese
pushed a commit
to open-sausages/silverstripe-admin
that referenced
this pull request
Nov 4, 2021
unclecheese
pushed a commit
to silverstripe/silverstripe-admin
that referenced
this pull request
Nov 5, 2021
* Use new public/_graphql/ subfolder location Relies on silverstripe/silverstripe-graphql#385 * Rebase and build Co-authored-by: Aaron Carlino <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is consistent with public/_resources which is also auto-generated by the CMS.
It enables sysadmins to lock down write access to public/ during runtime, with this potentially granular exception.
And it makes it easier to discover which part of the system is responsible for writing these files.
The change is backwards compatible with existing file locations,
although we probably want to remove that before going stable:
#384
Relies on equivalent PR to silverstripe/admin at silverstripe/silverstripe-admin#1222
The docs are already stating this new location so this was more of an oversight:
https://docs.silverstripe.org/en/4/developer_guides/graphql/getting_started/building_the_schema/#viewing-the-generated-code