Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix RequiredFields validation #195

Merged
merged 2 commits into from
Jan 31, 2024
Merged

Fix RequiredFields validation #195

merged 2 commits into from
Jan 31, 2024

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz commented Jan 30, 2024 •
edited
Loading

Two PR fixes two things in seperarte PRs, so do not squash merge

  1. Fixing non-inline editing of elements which was totally busted private static bool $inline_editable = false; on the content block
  2. Adds the new HasOneRelationFieldInterface to LinkField, which means that it can be used by the RequiredFields validator

Requires silverstripe/silverstripe-framework#11119 to be merged first

@emteknetnz emteknetnz mentioned this pull request Jan 30, 2024
Closed
GuySartorelli
GuySartorelli requested changes Jan 31, 2024
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small change.

src/Form/Traits/LinkFieldGetOwnerTrait.php Outdated Show resolved Hide resolved
@emteknetnz emteknetnz force-pushed the pulls/4/non-inline-editable-block branch from 3c6a037 to 09f637c Compare January 31, 2024 03:21
GuySartorelli
GuySartorelli approved these changes Jan 31, 2024
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, works well locally.

@GuySartorelli GuySartorelli merged commit ee002f4 into silverstripe:4 Jan 31, 2024
10 checks passed
@GuySartorelli GuySartorelli deleted the pulls/4/non-inline-editable-block branch January 31, 2024 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @GuySartorelli