FIX Archive record from live table on delete #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emteknetnz
commented
Feb 8, 2024
| @@ -500,7 +513,6 @@ public function testLinkDelete( | |||
| $owner = $this->getFixtureLinkOwner(); | |||
| $this->assertSame(0, $owner->LinkID); | |||
| } | |||
| $this->assertTrue(true); | |||
There was a problem hiding this comment.
This is unrelated refactoring to remove a pointless assertion
emteknetnz
force-pushed
the
pulls/4/versioned-delete
branch
from
97eee66
to
d634e15
Compare
GuySartorelli
requested changes
Feb 12, 2024
emteknetnz
force-pushed
the
pulls/4/versioned-delete
branch
3 times, most recently
from
60fd2dd
to
56bef66
Compare
GuySartorelli
requested changes
Feb 12, 2024
emteknetnz
force-pushed
the
pulls/4/versioned-delete
branch
from
56bef66
to
c347b35
Compare
GuySartorelli
approved these changes
Feb 13, 2024
There was a problem hiding this comment.
Looks great, works well locally.
There's some bad toasts when looking in the history tab, but that can be handled in #10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #213