MNT LinkField Jest tests #217
Conversation
sabina-talipova
force-pushed
the
pulls/4/linkfield-jest-test-2
branch
4 times, most recently
from
da22f5d
to
02b2357
Compare
sabina-talipova
force-pushed
the
pulls/4/linkfield-jest-test-2
branch
3 times, most recently
from
6afb506
to
590fe7a
Compare
| @@ -57,6 +57,67 @@ function makeProps(obj = {}) { | |||
| }; | |||
| } | |||
|
|
|||
| describe('Render existing links', () => { | |||
There was a problem hiding this comment.
Don't use describe(), it's unnecessary. Just use flat test(). When we did the large refactor on jest tests we went with the principles in this article - https://kentcdodds.com/blog/avoid-nesting-when-youre-testing which last linked from the react testing library docs
Remove describe() throughout this PR
| })} | ||
| />); | ||
| doResolve(); | ||
| await act(async () => { |
There was a problem hiding this comment.
Instead of using act(), use await screen.findByText('Page title');. You may need to import screen from react-testing-library. Update all references to act() in the PR
If there' no text to find try one of the other screen find* methods - https://testing-library.com/docs/queries/about/
If nothing there will work then just use act()
sabina-talipova
force-pushed
the
pulls/4/linkfield-jest-test-2
branch
2 times, most recently
from
729dd41
to
78aa111
Compare
| const { container } = render(<LinkFieldContext.Provider value={{ loading: false }}> | ||
| <LinkPickerMenu {...makeProps({ onSelect })} /> | ||
| </LinkFieldContext.Provider>); | ||
| await act(async () => { |
There was a problem hiding this comment.
Can this be converted to use await screen.findByText() ?
| const { container } = render(<LinkFieldContext.Provider value={{ loading: false }}> | ||
| <LinkPickerMenu {...makeProps({ onKeyDownEdit })} /> | ||
| </LinkFieldContext.Provider>); | ||
| await act(async () => { |
There was a problem hiding this comment.
Can this be converted to use await screen.findByText() ?
You'd put that below the await fireEvent.keyDown()
| @@ -1,6 +1,6 @@ | |||
| /* global jest, test, expect, document */ | |||
| import React from 'react'; | |||
| import { render, act, screen } from '@testing-library/react'; | |||
| import { render, screen, act } from '@testing-library/react'; | |||
There was a problem hiding this comment.
| import { render, screen, act } from '@testing-library/react'; | |
| import { render, screen } from '@testing-library/react'; |
There was a problem hiding this comment.
We use act here.
Comment says // Short wait - we can't use screen.find* because we're waiting for something to be removed, not added to the DOM. If we replace act with findText test is failed.
Updated. Replaces this part with waitFor() wrapper.
| /* global jest, test */ | ||
|
|
||
| import React from 'react'; | ||
| import { render, fireEvent, act } from '@testing-library/react'; |
There was a problem hiding this comment.
| import { render, fireEvent, act } from '@testing-library/react'; | |
| import { render, fireEvent, screen } from '@testing-library/react'; |
Assuming that act() can be replace with screen.findByText()
sabina-talipova
force-pushed
the
pulls/4/linkfield-jest-test-2
branch
3 times, most recently
from
74912c7
to
62f2c2b
Compare
sabina-talipova
force-pushed
the
pulls/4/linkfield-jest-test-2
branch
from
62f2c2b
to
2cb85f6
Compare
|
Updated |
Description
These tests ensure that all Components are rendered correctly when passing certain parameters. Does not cover cases of creating a modal window (they will be added to Behat tests).
Parent issue