NEW Globally disallow link types #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emteknetnz
force-pushed
the
pulls/4/disable-types
branch
3 times, most recently
from
9fdda0e
to
1bc4b73
Compare
emteknetnz
commented
Feb 13, 2024
| * | ||
| * @throws ReflectionException | ||
| */ | ||
| private function getLinkTypes(): array |
There was a problem hiding this comment.
This is method is unused
emteknetnz
force-pushed
the
pulls/4/disable-types
branch
from
1bc4b73
to
c8a71ba
Compare
emteknetnz
commented
Feb 13, 2024
| use SilverStripe\LinkField\Models\PhoneLink; | ||
| use SilverStripe\LinkField\Models\EmailLink; | ||
|
|
||
| class AbstractLinkFieldTest extends SapphireTest |
There was a problem hiding this comment.
I renamed this file and associated fixture files from LinkFieldTest
emteknetnz
commented
Feb 13, 2024
| 'Relation' => 'MyLink', | ||
| ], $res); | ||
| } | ||
|
|
There was a problem hiding this comment.
Below this line is new test code, above this line is existing code
sabina-talipova
suggested changes
Feb 13, 2024
README.md
Outdated
| Developers can control the link types allowed for individual `LinkField`. The `setAllowedTypes` method only allow link types that have been provided as parameters. | ||
| By default, all `Link` subclasses can be created by a `LinkField`. This includes any custom `Link` subclasses defined in your project or via a third party module. | ||
|
|
||
| If you wish to globally disable one of the default `Link` subclasses for all `LinkField` instances, then this can be done using the following YAML configuration, using the FQCN of the relevant default `Link` subclass you wish to disable: |
There was a problem hiding this comment.
Suggested change
| If you wish to globally disable one of the default `Link` subclasses for all `LinkField` instances, then this can be done using the following YAML configuration, using the FQCN of the relevant default `Link` subclass you wish to disable: | |
| If you wish to globally disable one of the default `Link` subclasses for all `LinkField` instances, then this can be done using the following YAML configuration, using the FQCN (Fully-Qualified Class Name) of the relevant default `Link` subclass you wish to disable: |
It would be nice to clarify, since we have not used this abbreviation before in the text.
emteknetnz
force-pushed
the
pulls/4/disable-types
branch
from
c8a71ba
to
0c0cdaa
Compare
sabina-talipova
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #212