NEW LinkableMigrationTask for migrating sheadawson-lin kable links #261
Conversation
sabina-talipova
force-pushed
the
pulls/4/migration-task-linkable-2
branch
from
0288f89
to
4971a3c
Compare
sabina-talipova
force-pushed
the
pulls/4/migration-task-linkable-2
branch
19 times, most recently
from
46b933b
to
1d20319
Compare
| /** | ||
| * Returns true if the class represents an old link to be migrated | ||
| */ | ||
| abstract private function classIsOldLink(string $class): bool; |
There was a problem hiding this comment.
The method classIsOldLink have been removed as redundant.
There was a problem hiding this comment.
Has this been tested with the gorriecoe migration task to make sure it doesn't cause problems there?
sabina-talipova
force-pushed
the
pulls/4/migration-task-linkable-2
branch
3 times, most recently
from
8fce8e9
to
4c7fbfc
Compare
| /** | ||
| * Returns true if the class represents an old link to be migrated | ||
| */ | ||
| abstract private function classIsOldLink(string $class): bool; |
There was a problem hiding this comment.
Has this been tested with the gorriecoe migration task to make sure it doesn't cause problems there?
sabina-talipova
force-pushed
the
pulls/4/migration-task-linkable-2
branch
2 times, most recently
from
c0773a7
to
9b3de66
Compare
sabina-talipova
force-pushed
the
pulls/4/migration-task-linkable-2
branch
19 times, most recently
from
f382b2e
to
5beb60d
Compare
No, there are not any new changes in the code, except one. I moved |
sabina-talipova
force-pushed
the
pulls/4/migration-task-linkable-2
branch
3 times, most recently
from
cbe6b9b
to
458b3cb
Compare
sabina-talipova
force-pushed
the
pulls/4/migration-task-linkable-2
branch
from
458b3cb
to
4d9c84f
Compare
Description
These changes use the already developed logic of
GorriecoeMigrationTaskclass. Since the Model structure of these two modules is almost identical, commonGorriecoeMigrationTasklogic was separated into aModuleMigrationTaskTraitand implemented inLinkableMigrationTaskfor ease of support in the future.Also, minor changes were made to
MigrationTaskTraitand theclassIsOldLinkclass method was removed. Tests have been added and documentation on migration from theLinkablemodule toLinkFieldhas been updated.Parent issue
Note: For further implementation, it is required that this PR be merged into the main branch 4 first.