Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT Add extension in finally block #316

Merged

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz commented Aug 12, 2024

Issue #317

Add the Versioned extension back in using a finally block to prevent any bleed over to other tests in case the test fails

Also upgrades == to standard ===

Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. LGTM

@GuySartorelli GuySartorelli merged commit e19de2b into silverstripe:4.0 Aug 12, 2024
15 checks passed
@GuySartorelli GuySartorelli deleted the pulls/4.0/candeletetest branch August 12, 2024 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants