Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove silverstripe/admin dependency #123

Open
lekoala opened this issue Sep 21, 2022 · 0 comments
Open

remove silverstripe/admin dependency #123

lekoala opened this issue Sep 21, 2022 · 0 comments
Labels
complexity/low impact/low type/enhancement New feature or request

Comments

@lekoala
Copy link

lekoala commented Sep 21, 2022

At the moment, there is this line in the template

silverstripe-login-forms/themes/login-forms/templates/Security.ss

Line 12 in e0882c2

<% require css("silverstripe/admin: client/dist/styles/bundle.css") %>

which means the default template doesn't work without the silverstripe/admin module. Since it isn't specified in the composer.json file, I think it would be nice if these styles were made optional. I've removed that line and it doesn't seem to have much impact anyway on the layout.
UndefinedOffset added a commit to webbuilders-group/silverstripe-remember-my-account that referenced this issue Jul 6, 2023
@UndefinedOffset
Added silvrestripe/admin to dependencies for tests see silverstripe/s…
fb27823 
…ilverstripe-login-forms#123
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
complexity/low impact/low type/enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lekoala @GuySartorelli