Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: add metatags to template #161

Open
wants to merge 1 commit into
base: 5
Choose a base branch
from

Conversation

sunnysideup
Copy link

@sunnysideup sunnysideup commented Jan 8, 2024

Description

image

The Metatags listed here return nothing. We should either remove them or link to SiteTree. I have linked to SiteTree here.

Also, we should be consistent and always talk about MetaTags with two capitals.

Manual testing steps

Issues

Pull request checklist

  • The target branch is correct
  • All commits are relevant to the purpose of the PR (e.g. no debug statements, unrelated refactoring, or arbitrary linting)
    • Small amounts of additional linting are usually okay, but if it makes it hard to concentrate on the relevant changes, ask for the unrelated changes to be reverted, and submitted as a separate PR.
  • The commit messages follow our commit message guidelines
  • The PR follows our contribution guidelines
  • Code changes follow our coding conventions
  • This change is covered with tests (or tests aren't necessary for this change)
  • Any relevant User Help/Developer documentation is updated; for impactful changes, information is added to the changelog for the intended release
  • CI is green

@GuySartorelli
Copy link
Member

Hi there,

Thank you for your contribution.
I notice that you didn't follow the pull request template - I've added that template back in to your pull request description. Please fill in all of the relevant information and follow the documented contribution guidelines.

@sunnysideup
Copy link
Author

sunnysideup commented Jan 11, 2024

I will do my best. I know I am one of the laziest people when it comes to making pull requests. I do plenty for the open source community, but I lack the time to do all of this stuff - so I double-muchly appreciate all your help!

I would never mind if someone else would take my code and add it with the required bits to make it their commit.

When I have an opportunity I will finish this.

@sunnysideup
Copy link
Author

@GuySartorelli - do you think it is worthwhile adding?

@GuySartorelli
Copy link
Member

GuySartorelli commented Jan 11, 2024

do you think it is worthwhile adding?

If you mean the template information, then yes it is worthwhile. Using this template ensures:

  1. The person making the contribution (in this case you) has read and followed the contribution guidelines
  2. The commits are all relevant
  3. The commit messages are all formatted correctly
  4. There are tests if appropriate
  5. Docs are updated as appropriate
  6. There is an issue for us to track and add any discussion to if needed

Basically, it makes it a lot easier to manage contributions to all of the supported modules

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants