Update doc blocks, optimise imports, prefer short array syntax

silverstripe · Jul 15, 2019 · 0454110 · 0454110
1 parent b05cddd
commit 0454110
Showing 1 changed file with 7 additions and 7 deletions.
diff --git a/tests/php/Authenticator/LoginHandlerTest.php b/tests/php/Authenticator/LoginHandlerTest.php
@@ -2,7 +2,6 @@
 
 namespace SilverStripe\MFA\Tests\Authenticator;
 
-use Page;
 use PHPUnit_Framework_MockObject_MockObject;
 use SilverStripe\Control\Controller;
 use SilverStripe\Control\HTTPRequest;
@@ -234,8 +233,9 @@ public function cannotSkipMFAProvider()
     }
 
     /**
-     * @param $memberFixture
-     * @param $expectedRedirect
+     * @param string $memberFixture
+     * @param bool $mfaRequiredInGrace
+     * @param string|null $expectedRedirect
      * @dataProvider skipRegistrationProvider
      */
     public function testSkipRegistration($memberFixture, $mfaRequiredInGrace = false, $expectedRedirect = null)
@@ -286,7 +286,7 @@ public function skipRegistrationProvider()
     }
 
     /**
-     * @param $memberFixture
+     * @param string $memberFixture
      * @dataProvider methodlessMemberFixtureProvider
      */
     public function testBackURLIsPreservedWhenSkipping($memberFixture)
@@ -486,7 +486,7 @@ public function testFinishVerificationPassesExceptionMessagesThroughFromMethodsW
     }
 
     /**
-     * @param $memberFixture
+     * @param string $memberFixture
      * @dataProvider methodlessMemberFixtureProvider
      */
     public function testFinishVerificationWillRedirectToTheBackURLSetAsLoginIsStarted($memberFixture)
@@ -572,12 +572,12 @@ protected function doLogin(Member $member, $password, $backUrl = null)
         return $this->submitForm(
             'MemberLoginForm_LoginForm',
             null,
-            array(
+            [
                 'Email' => $member->Email,
                 'Password' => $password,
                 'AuthenticationMethod' => MemberAuthenticator::class,
                 'action_doLogin' => 1,
-            )
+            ]
         );
     }