FIX Users without CMS access are now able to log in correctly #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code change seems fine, but there are test failures. |
This fixes an issue that would continue to redirect the user to MFA after they logged in, ending up in a redirect loop. This patch checks whether it should redirect to MFA as well as checking if the registration is not complete yet before executing this logic.
robbieaverill
force-pushed
the
pulls/4.0/redirect-loop
branch
from
83a424f
to
d9f8e8c
Compare
|
Thanks, I've pushed a fix to ensure that the back URL is respected when this happens |
Cheddam
approved these changes
Jun 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue that would continue to redirect the user to MFA after they logged in, ending up in a redirect loop. This patch checks whether it should redirect to MFA as well as checking if the registration is not complete yet before executing this logic.
Fixes #204