FIX Export registered methods in enabled members report #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 15, 2022
emteknetnz
force-pushed
the
pulls/4/export-colummns
branch
from
d72adf3
to
b71d8e3
Compare
src/Report/EnabledMembers.php
Outdated
| @@ -153,6 +151,7 @@ public function parameterFields(): FieldList | |||
| * @param null $_ | |||
| * @param Member $record | |||
| * @return string | |||
| * @deprecated use MemberExtension::getRegisteredMethodNames() instead | |||
There was a problem hiding this comment.
Do we want to signal a version when these methods going to be removed (if at all)?
There was a problem hiding this comment.
May as well, have updated
|
Test failure related. |
emteknetnz
force-pushed
the
pulls/4/export-colummns
branch
from
b71d8e3
to
258b9f5
Compare
emteknetnz
force-pushed
the
pulls/4/export-colummns
branch
from
258b9f5
to
fe32efe
Compare
michalkleiner
approved these changes
Jan 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #443
GridFieldExportButton doesn't apply formatting. I actually try fixing it that way first here before realizing this is probably bad because the exported data may included HTML link hyperlinks which will looks really bad in a csv
So I think the proper solution is don't manipulate data in a formatting function, instead just create some new 'get' methods that do the data manipulation
Also fixed some phpcs issues