Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX Expose localisations #139

Merged
merged 1 commit into from
Oct 5, 2023
Merged

FIX Expose localisations #139

merged 1 commit into from
Oct 5, 2023

Conversation

GuySartorelli
Copy link
Member

Localisation files weren't exposed via composer vendor-expose, and also weren't being required via the requirements API. Because of this, only the default (English) strings were ever used.

Issue

@GuySartorelli GuySartorelli changed the base branch from 5 to 4.6 October 4, 2023 22:58
@GuySartorelli GuySartorelli reopened this Oct 4, 2023
@GuySartorelli GuySartorelli mentioned this pull request Oct 4, 2023
Closed
emteknetnz
emteknetnz approved these changes Oct 5, 2023
View reviewed changes
Copy link
Member

@emteknetnz emteknetnz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, tested locally with language set to Dutch

Before
image

After
image

@emteknetnz emteknetnz merged commit b77fbb4 into silverstripe:4.6 Oct 5, 2023
23 of 24 checks passed
@emteknetnz emteknetnz deleted the pulls/4.6/expose-localisation branch October 5, 2023 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emteknetnz emteknetnz emteknetnz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GuySartorelli @emteknetnz