Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MNT Remove TODO comments #1247

Merged
merged 1 commit into from
Oct 19, 2023
Merged

MNT Remove TODO comments #1247

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions code/Form/UserForm.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,8 +135,6 @@ public function getFormFields()
* can manipulate these by using {@link updateFormActions()} on
* a decorator.
*
* @todo Make form actions editable via their own field editor.
*
* @return FieldList
*/
public function getFormActions()
Expand Down
1 change: 0 additions & 1 deletion code/Model/EditableFormField/EditableCheckboxGroupField.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@ public function getValueFromData($data)
public function getSelectorField(EditableCustomRule $rule, $forOnLoad = false)
{
// watch out for checkboxs as the inputs don't have values but are 'checked
// @todo - Test this
if ($rule->FieldValue) {
return "$(\"input[name='{$this->Name}[]'][value='{$rule->FieldValue}']\")";
} else {
Expand Down
1 change: 0 additions & 1 deletion code/Model/EditableFormField/EditableLiteralField.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,6 @@ public function getFormField()

$field = CompositeField::create($content)
->setName($this->Name)
// ->setID($this->Name) // @todo: https://github.com/silverstripe/silverstripe-framework/issues/7264
->setFieldHolderTemplate(__CLASS__ . '_holder');

$this->doUpdateFormField($field);
Expand Down
2 changes: 1 addition & 1 deletion code/Model/Recipient/EmailRecipient.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ protected function getFormParent()
}

// Revert to checking for a form from the session
// LeftAndMain::sessionNamespace is protected. @todo replace this with a non-deprecated equivalent.
// LeftAndMain::sessionNamespace is protected.
$sessionNamespace = $this->config()->get('session_namespace') ?: CMSMain::class;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked another places where we get session_namespace and only here we have notification to replace this with a non-deprecated equivalent.


$formID = Controller::curr()->getRequest()->getSession()->get($sessionNamespace . '.currentPage');
Expand Down
2 changes: 0 additions & 2 deletions code/Task/RecoverUploadLocationsHelper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -447,8 +447,6 @@ private function chunk($chunkSize = 100)
'"SubmittedFileFieldTable"."UploadedFileID" > ?' => $greaterThanID
])->execute();

// TODO: Versioned::prepopulate_versionnumber_cache

foreach ($chunk as $item) {
yield $item;
$greaterThanID = $item['UploadedFileID'];
Expand Down
1 change: 0 additions & 1 deletion tests/php/Model/UserDefinedFormTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@ public function testRollbackToVersion()
'UserDefinedForm::rollback() has not been implemented completely'
);

// @todo
$this->logInWithPermission('ADMIN');
/** @var UserDefinedForm|Versioned $form */
$form = $this->objFromFixture(UserDefinedForm::class, 'basic-form-page');
Expand Down