MNT Fix behat test #1254
Closed
MNT Fix behat test #1254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuySartorelli
requested changes
Dec 5, 2023
GuySartorelli
approved these changes
Dec 6, 2023
GuySartorelli
requested changes
Dec 6, 2023
| @@ -8,6 +8,7 @@ Feature: Userforms | |||
| And the "group" "ADMIN group" has permissions "Full administrative rights" | |||
| And a "group" "ADMIN group" has the "Code" "administrators" | |||
|
|
|||
| @sboyd | |||
There was a problem hiding this comment.
Suggested change
| @sboyd |
Still there? Sounds like GitHub is having a moment... I'll look back again in an hour or so.
There was a problem hiding this comment.
Issue is that I pushed to silverstripe account instead of creative commoners
|
Closed in favor of #1255 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue silverstripe/.github#169
Fix for https://github.com/silverstripe/silverstripe-userforms/actions/runs/7032661173/job/19266531442 which is breaking in CMS 5
There was a previously behat fix on 5.15 https://github.com/silverstripe/silverstripe-userforms/pull/1253/files which duplicated selecting 'File upload field' as the element type.
While that seems to work in 5.15 doesn't it doesn't in 6.1 as the change handler isn't fired on the drop down field and the folder select modal doesn't pop up
I've simply removed the duplicate drop down select in the PR and add some "wait for x seconds"
When this is merged assign by to me to do a manual merge up