Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH - Add 'Includes' condition option to EmailRecipientCondition #1275

Merged
merged 2 commits into from
Mar 17, 2024
Merged

ENH - Add 'Includes' condition option to EmailRecipientCondition #1275

merged 2 commits into from
Mar 17, 2024

Conversation

sukhwinder-somar
Copy link
Contributor

@sukhwinder-somar sukhwinder-somar commented Mar 12, 2024

Description

Manual testing steps

Issues

Pull request checklist

  • The target branch is correct
  • All commits are relevant to the purpose of the PR (e.g. no debug statements, unrelated refactoring, or arbitrary linting)
    • Small amounts of additional linting are usually okay, but if it makes it hard to concentrate on the relevant changes, ask for the unrelated changes to be reverted, and submitted as a separate PR.
  • The commit messages follow our commit message guidelines
  • The PR follows our contribution guidelines
  • Code changes follow our coding conventions
  • This change is covered with tests (or tests aren't necessary for this change)
  • Any relevant User Help/Developer documentation is updated; for impactful changes, information is added to the changelog for the intended release
  • CI is green

@michalkleiner
Copy link
Contributor

Can you please fill in the PR template information @sukhwinder-somar and run through the checklist? You can skip the CI is green as you can't trigger it.

@sukhwinder-somar
Copy link
Contributor Author

@michalkleiner - I have gone through the checklist and checked

@michalkleiner
Copy link
Contributor

Thanks for doing that. Have you also read the points and the pages they link to before checking the checkboxes? For example the commit message doesn't specify the type of the change, the issue is not linked in the PR description. We don't want to discourage contributions, but helping us by ensuring high quality of the PRs can make the review and merge faster.

@sukhwinder-somar sukhwinder-somar changed the title Add 'Includes' condition option to EmailRecipientCondition ENH - Add 'Includes' condition option to EmailRecipientCondition Mar 12, 2024
@sukhwinder-somar
Copy link
Contributor Author

Sure bud, I have gone through it, please let me know if you see anything else wrong in commit's heading or something else.....

@GuySartorelli
Copy link
Member

GuySartorelli commented Mar 12, 2024

Thanks for submitting this PR.
Note that you changed the PR title, but not the actual commit message:
commit-message

Can you please update the commit message to include the correct prefix?

# This will let you change the commit message
git commit --amend
# you'll need to force push afterward
git push --force-with-lease

@sukhwinder-somar
Copy link
Contributor Author

sukhwinder-somar commented Mar 12, 2024

@GuySartorelli - Morning mate, I have changed the commit message as per direction

Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small change

code/Model/Recipient/EmailRecipientCondition.php Outdated Show resolved Hide resolved
@sukhwinder-somar
Copy link
Contributor Author

@GuySartorelli - sweet, committed the suggested code

Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@GuySartorelli GuySartorelli merged commit 32d0158 into silverstripe:6 Mar 17, 2024
12 checks passed
@sukhwinder-somar sukhwinder-somar deleted the 6-added-additional-option-in-EmailRecipientCondition branch March 18, 2024 00:15
thisisannie pushed a commit to thisisannie/silverstripe-userforms that referenced this pull request Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants