DEP Upgrade frontend build stack #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuySartorelli
commented
Jan 25, 2023
| @@ -19,32 +18,33 @@ | |||
| "lint-sass": "sass-lint client/src" | |||
| }, | |||
| "dependencies": { | |||
| "@silverstripe/react-injector": "^0.1.2", | |||
There was a problem hiding this comment.
This is exposed by the mfa module - not needed here
GuySartorelli
commented
Jan 25, 2023
| name: 'js', | ||
| entry: { | ||
| bundle: `${PATHS.SRC}/bundles/bundle.js`, | ||
| injector: `${PATHS.MODULES}/@silverstripe/react-injector/dist/injector.js`, |
There was a problem hiding this comment.
This is exposed by the mfa module - not needed here
GuySartorelli
force-pushed
the
pulls/5/frontend-build-stack
branch
from
ebaea10
to
8f2c94f
Compare
GuySartorelli
force-pushed
the
pulls/5/frontend-build-stack
branch
from
8f2c94f
to
36a60de
Compare
emteknetnz
approved these changes
Jan 30, 2023
|
Note - manual testing showed it's still broken - will be fixed in this issue - #124 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the following for a wider discussion on most of the changes:
Parent issue