FIX Skip expose calls when 'none' mode is enabled

silverstripe · Sep 5, 2019 · 32ba6fd · 32ba6fd
1 parent cf66429
commit 32ba6fd
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/src/VendorExposeTask.php b/src/VendorExposeTask.php
@@ -75,6 +75,10 @@ public function process(IOInterface $io, array $libraries, $methodKey = null)
         }
         $method = $this->getMethod($methodKey);
 
+        if ($methodKey === VendorPlugin::METHOD_NONE) {
+            return;
+        }
+
         // Update all modules
         foreach ($libraries as $module) {
             // Skip this module if no exposure required
@@ -138,8 +142,8 @@ protected function getMethod($key)
             case JunctionMethod::NAME:
                 return new JunctionMethod();
             case VendorPlugin::METHOD_NONE:
-                // 'none' is forced to an empty chain
-                return new ChainedMethod([]);
+                // 'none' is forced to an empty chain (and doesn't run anyway)
+                return new ChainedMethod();
             case VendorPlugin::METHOD_AUTO:
                 // Default to safe-failover method
                 if (Platform::isWindows()) {