API Update deprecations #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
3 tasks
emteknetnz
force-pushed
the
pulls/1/deprecated
branch
from
47697b7
to
3dce6eb
Compare
src/Console/VendorExposeCommand.php
Outdated
| @@ -2,6 +2,7 @@ | |||
|
|
|||
| namespace SilverStripe\VendorPlugin\Console; | |||
|
|
|||
| use SilverStripe\Dev\Deprecation; | |||
There was a problem hiding this comment.
Framework isn't a dependency - does this even work? Same as with recipe-plugin, I'm unsure if this is appropriate or not.
There was a problem hiding this comment.
Have removed Deprecation::notice() - we cannot use it here because this is a composer plugin. I've added an AC to silverstripe/silverstripe-framework#10501 to ensure that the deprecated code is still removed correctly despite the lack of Deprecation::notice()
emteknetnz
force-pushed
the
pulls/1/deprecated
branch
from
3dce6eb
to
9e30c80
Compare
GuySartorelli
approved these changes
Oct 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue silverstripe/silverstripe-framework#10531