Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dishwasher User Settings doesnt match values set by gehomesdk #155

Closed
csfreak opened this issue Apr 25, 2023 · 0 comments
Closed

Dishwasher User Settings doesnt match values set by gehomesdk #155

csfreak opened this issue Apr 25, 2023 · 0 comments

Comments

@csfreak
Copy link

csfreak commented Apr 25, 2023

The know_entities map for dishwasher devices includes a entity named sound, which does not exist in the Object defined by gehomesdk

I happy to submit a pr, but wanted to open an issue so you could decide which way you wanted to fix it, especially given the notes here

2023-04-25 18:45:36.411 ERROR (MainThread) [homeassistant.components.sensor] Error adding entities for domain sensor with platform ge_home
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 455, in async_add_entities
await asyncio.gather(*tasks)
File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 731, in _async_add_entity
await entity.add_to_platform_finish()
File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 823, in add_to_platform_finish
self.async_write_ha_state()
File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 568, in async_write_ha_state
self._async_write_ha_state()
File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 632, in _async_write_ha_state
state = self._stringify_state(available)
File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 574, in _stringify_state
if (state := self.state) is None:
File "/usr/src/homeassistant/homeassistant/components/sensor/init.py", line 470, in state
value = self.native_value
File "/config/custom_components/ge_home/entities/common/ge_erd_property_sensor.py", line 39, in native_value
value = magicattr.get(self.appliance.get_erd_value(self.erd_code), self.erd_property)
File "/config/deps/lib/python3.10/site-packages/magicattr.py", line 46, in get
raise ex
File "/config/deps/lib/python3.10/site-packages/magicattr.py", line 41, in get
obj = _lookup(obj, chunk)
File "/config/deps/lib/python3.10/site-packages/magicattr.py", line 197, in _lookup
return getattr(obj, node.id)
AttributeError: 'ErdUserSetting' object has no attribute 'sound'

simbaja added a commit that referenced this issue Apr 30, 2023
- added oim descaling sensor (#154)
- version bump
simbaja added a commit that referenced this issue Apr 30, 2023
* - updated water heater naming

* - initial support for built-in AC units

* Add support for Built-In AC Unit

Built-In AC unit operation and function is similar to a WAC.
`gehomesdk` version bumped from 0.4.25 to 0.4.27 to include latest
ErdApplianceType enum.

* Update README.md

Update README.md to include Built-In AC as supported device

* - updated zero serial number detection (resolves #89)

* - updated version
- updated changelog

* - hopefully fixed recursion bug with numbers

* - added cooktop support

* - fixed circular reference

* Add support for fridges with reduced support for ERD codes (no turbo mode, no current temperature reporting, no temperature setpoint limit reporting, no door status reporting). This change has been tested on a Fisher & Paykel RF610AA.

* - added dual dishwasher support
- updated documentation
- version bumps

* - added water heater support

* - added basic espresso maker device

* - bugfixes

* - rewrote initialization (resolves #99)

* - added logic to prevent double registration of entities

* - added correct min/max temps for water heaters

* Fix CoffeeMaker after the NumberEntity refactoring

* - added fix for CGY366P2TS1 (#116) to try to get the cooktop status, but fail more gracefully if it isn't supported

* - fixed region setting in update coordinator

* - version bump
- doc update
- string fixes

* - updated the temperature conversion to use non-deprecated HASS methods

* - updated documentation (@gleepwurp)

* - more documentation updates

* - updated dishwasher for new functionality
- updated documentation

* updated uom for liquid volume per HA specifications

* - fixed typo in oven (#149)

* - updated change log
- fixed oven light control (#144)

* - fixed issues with dishwasher (#155)
- added oim descaling sensor (#154)
- version bump

* - updated change log

---------

Co-authored-by: Rob Schmidt <[email protected]>
Co-authored-by: Federico Sevilla <[email protected]>
Co-authored-by: alexanv1 <[email protected]>
@simbaja simbaja closed this as completed Apr 30, 2023
simbaja added a commit that referenced this issue Sep 10, 2023
* - updated water heater naming

* - initial support for built-in AC units

* Add support for Built-In AC Unit

Built-In AC unit operation and function is similar to a WAC.
`gehomesdk` version bumped from 0.4.25 to 0.4.27 to include latest
ErdApplianceType enum.

* Update README.md

Update README.md to include Built-In AC as supported device

* - updated zero serial number detection (resolves #89)

* - updated version
- updated changelog

* - hopefully fixed recursion bug with numbers

* - added cooktop support

* - fixed circular reference

* Add support for fridges with reduced support for ERD codes (no turbo mode, no current temperature reporting, no temperature setpoint limit reporting, no door status reporting). This change has been tested on a Fisher & Paykel RF610AA.

* - added dual dishwasher support
- updated documentation
- version bumps

* - added water heater support

* - added basic espresso maker device

* - bugfixes

* - rewrote initialization (resolves #99)

* - added logic to prevent double registration of entities

* - added correct min/max temps for water heaters

* Fix CoffeeMaker after the NumberEntity refactoring

* - added fix for CGY366P2TS1 (#116) to try to get the cooktop status, but fail more gracefully if it isn't supported

* - fixed region setting in update coordinator

* - version bump
- doc update
- string fixes

* - updated the temperature conversion to use non-deprecated HASS methods

* - updated documentation (@gleepwurp)

* - more documentation updates

* - updated dishwasher for new functionality
- updated documentation

* updated uom for liquid volume per HA specifications

* - fixed typo in oven (#149)

* - updated change log
- fixed oven light control (#144)

* - fixed issues with dishwasher (#155)
- added oim descaling sensor (#154)
- version bump

* - updated change log

* updated dual dishwasher for changes to gehomesdk (#161)

Co-authored-by: na4ma4 <[email protected]>

* await disconnect when unloading (#169)

Fixes #164.

* Check for upper oven light when there is a lower oven (#174)

Resolves issue #121

* - added oven warming drawers
- simplified oven entity logic

* - fixed issues with the new oven initialization logic

* - fixed bad type import for warming drawer

* -added iot class (#181)

* - updated the gehomesdk version requirement

* - gehomesdk version bump

* - added dehumidifier (#114)

* - dehumidifier appliance type fix

* - added oven state sensors (#175)

* - updated change logs
- updated sdk version requirement

* - removed target select
- added dehumidifier entity
- sdk version bump

* - updated dehumidifier icon

* - added humidifier platform

* - fixed typos in humidifier class

* - fixed copy/paste error

* - sdk version requirement bump

* - sdk version bump

* - updated dehumidifier to handle target precision
- updated dehumidifier sensor value conversion

* - missed a commit

* - SDK version bump

---------

Co-authored-by: Rob Schmidt <[email protected]>
Co-authored-by: Federico Sevilla <[email protected]>
Co-authored-by: alexanv1 <[email protected]>
Co-authored-by: na4ma4 <[email protected]>
Co-authored-by: na4ma4 <[email protected]>
Co-authored-by: Alex Peters <[email protected]>
Co-authored-by: Chris Petersen <[email protected]>
simbaja added a commit that referenced this issue Jan 28, 2024
* - updated water heater naming

* - initial support for built-in AC units

* Add support for Built-In AC Unit

Built-In AC unit operation and function is similar to a WAC.
`gehomesdk` version bumped from 0.4.25 to 0.4.27 to include latest
ErdApplianceType enum.

* Update README.md

Update README.md to include Built-In AC as supported device

* - updated zero serial number detection (resolves #89)

* - updated version
- updated changelog

* - hopefully fixed recursion bug with numbers

* - added cooktop support

* - fixed circular reference

* Add support for fridges with reduced support for ERD codes (no turbo mode, no current temperature reporting, no temperature setpoint limit reporting, no door status reporting). This change has been tested on a Fisher & Paykel RF610AA.

* - added dual dishwasher support
- updated documentation
- version bumps

* - added water heater support

* - added basic espresso maker device

* - bugfixes

* - rewrote initialization (resolves #99)

* - added logic to prevent double registration of entities

* - added correct min/max temps for water heaters

* Fix CoffeeMaker after the NumberEntity refactoring

* - added fix for CGY366P2TS1 (#116) to try to get the cooktop status, but fail more gracefully if it isn't supported

* - fixed region setting in update coordinator

* - version bump
- doc update
- string fixes

* - updated the temperature conversion to use non-deprecated HASS methods

* - updated documentation (@gleepwurp)

* - more documentation updates

* - updated dishwasher for new functionality
- updated documentation

* updated uom for liquid volume per HA specifications

* - fixed typo in oven (#149)

* - updated change log
- fixed oven light control (#144)

* - fixed issues with dishwasher (#155)
- added oim descaling sensor (#154)
- version bump

* - updated change log

* updated dual dishwasher for changes to gehomesdk (#161)

Co-authored-by: na4ma4 <[email protected]>

* await disconnect when unloading (#169)

Fixes #164.

* Check for upper oven light when there is a lower oven (#174)

Resolves issue #121

* - added oven warming drawers
- simplified oven entity logic

* - fixed issues with the new oven initialization logic

* - fixed bad type import for warming drawer

* -added iot class (#181)

* - updated the gehomesdk version requirement

* - gehomesdk version bump

* - added dehumidifier (#114)

* - dehumidifier appliance type fix

* - added oven state sensors (#175)

* - updated change logs
- updated sdk version requirement

* - removed target select
- added dehumidifier entity
- sdk version bump

* - updated dehumidifier icon

* - added humidifier platform

* - fixed typos in humidifier class

* - fixed copy/paste error

* - sdk version requirement bump

* - sdk version bump

* - updated dehumidifier to handle target precision
- updated dehumidifier sensor value conversion

* - missed a commit

* - SDK version bump

* Set device class on day flow for water softeners (#207)

This should allow sensor to be added to the energy dashboard.

* - removed references to _hass in update coordinator
- removed hass attribute in ge_entity
- version bump

* bumped gehomesdk version requirement

* - added fridge/freezer controls

* - documentation updates

* - fixed error when reloading integration

* - added additional update error handling

* - fixed coordinator bug

* - added additional logic to handle non-standard ready conditions

* Set device class on day flow for water filters (#209)

* - bumped sdk version requirement

* added new style cooktop status support (#159)

* Update deprecated constants or remove unused ones (#219)

* - updated documentation

---------

Co-authored-by: Rob Schmidt <[email protected]>
Co-authored-by: Federico Sevilla <[email protected]>
Co-authored-by: alexanv1 <[email protected]>
Co-authored-by: na4ma4 <[email protected]>
Co-authored-by: na4ma4 <[email protected]>
Co-authored-by: Alex Peters <[email protected]>
Co-authored-by: Chris Petersen <[email protected]>
Co-authored-by: Nathan Fiscus <[email protected]>
Co-authored-by: Jason Foley <[email protected]>
Co-authored-by: myztillx <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants