Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/x86arch #246

Merged
merged 5 commits into from
Oct 7, 2022
Merged

Fix/x86arch #246

merged 5 commits into from
Oct 7, 2022

Conversation

universalmind303
Copy link
Contributor

fixes #245

@Licenser
Copy link
Member

Licenser commented Oct 4, 2022

Heya,

sorry for the late reply, I was very busy vacationing and not looking at computers :D.

this looks great, good catch!

Copy link
Member

@Licenser Licenser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice! Thank you :)

@Licenser Licenser enabled auto-merge (rebase) October 4, 2022 08:13
@codecov
Copy link

codecov bot commented Oct 4, 2022

Codecov Report

Base: 82.60% // Head: 82.60% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (c36a4b0) compared to base (e07e37f).
Patch coverage: 75.32% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #246      +/-   ##
==========================================
- Coverage   82.60%   82.60%   -0.01%     
==========================================
  Files          34       34              
  Lines       10595    10623      +28     
==========================================
+ Hits         8752     8775      +23     
- Misses       1843     1848       +5     
Flag Coverage Δ
82.01% <71.21%> (+0.76%) ⬆️
128bit 82.48% <75.32%> (+0.40%) ⬆️
avx2 82.11% <75.32%> (+<0.01%) ⬆️
beef 82.57% <75.32%> (+0.70%) ⬆️
knownkey 82.58% <75.32%> (+0.50%) ⬆️
pclmulqdq 82.07% <75.00%> (+0.75%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/serde/se.rs 84.13% <0.00%> (+0.25%) ⬆️
src/serde/se/pp.rs 50.66% <0.00%> (+0.19%) ⬆️
src/serde/de.rs 84.26% <54.28%> (-2.56%) ⬇️
src/error.rs 75.00% <83.33%> (-5.96%) ⬇️
src/lib.rs 97.48% <100.00%> (+0.04%) ⬆️
src/numberparse.rs 91.03% <100.00%> (ø)
src/sse42/deser.rs 100.00% <100.00%> (ø)
src/sse42/stage1.rs 98.08% <100.00%> (-0.08%) ⬇️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Licenser
Copy link
Member

Licenser commented Oct 4, 2022

@universalmind303 could you run cargo fmt over this otherwise it's looking great :)

auto-merge was automatically disabled October 6, 2022 16:17

Head branch was pushed to by a user without write access

@Licenser Licenser merged commit 669e691 into simd-lite:main Oct 7, 2022
@Licenser
Copy link
Member

Licenser commented Oct 7, 2022

Thanks a lot mate :D

@PigeonF PigeonF mentioned this pull request Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

failed to resolve: could not find x86_64 in arch on x86 arch.
2 participants