Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tuple variant serialization with serde #396

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

Licenser
Copy link
Member

@Licenser Licenser commented Oct 8, 2024

No description provided.

@Licenser Licenser linked an issue Oct 8, 2024 that may be closed by this pull request
@Licenser Licenser force-pushed the 395-invalid-serialization-of-tuple-enum-variants branch from dc172e4 to 657075f Compare October 8, 2024 14:48
Copy link

github-actions bot commented Oct 8, 2024

Benchmark for 2bd4b57

Click to view benchmark
Test Base PR %
apache_builds/simd_json::to_tape_with_buffers 93.2±2.11µs 94.5±2.48µs +1.39%
canada/simd_json::to_tape_with_buffers 3.7±0.16ms 3.8±0.19ms +2.70%
citm_catalog/simd_json::to_tape_with_buffers 1151.2±86.74µs 1151.8±84.77µs +0.05%
event_stacktrace_10kb/simd_json::to_tape_with_buffers 3.8±0.17µs 3.9±0.25µs +2.63%
github_events/simd_json::to_tape_with_buffers 41.5±1.07µs 41.5±1.17µs 0.00%
log/simd_json::to_tape_with_buffers 1579.0±96.16ns 1659.3±114.75ns +5.09%
twitter/simd_json::to_tape_with_buffers 447.1±26.17µs 447.5±26.83µs +0.09%

Copy link

github-actions bot commented Oct 8, 2024

Benchmark for 3e13db9

Click to view benchmark
Test Base PR %
apache_builds/simd_json::to_tape_with_buffers 91.5±1.16µs 92.1±1.32µs +0.66%
canada/simd_json::to_tape_with_buffers 4.0±0.18ms 3.8±0.16ms -5.00%
citm_catalog/simd_json::to_tape_with_buffers 1139.2±84.59µs 1144.2±85.43µs +0.44%
event_stacktrace_10kb/simd_json::to_tape_with_buffers 3.7±0.17µs 3.7±0.20µs 0.00%
github_events/simd_json::to_tape_with_buffers 40.4±0.74µs 40.3±0.78µs -0.25%
log/simd_json::to_tape_with_buffers 1537.7±74.30ns 1614.9±75.69ns +5.02%
twitter/simd_json::to_tape_with_buffers 444.6±25.76µs 444.6±25.53µs 0.00%

@Licenser Licenser merged commit c86fd8e into main Oct 8, 2024
23 checks passed
@Licenser Licenser deleted the 395-invalid-serialization-of-tuple-enum-variants branch October 8, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid serialization of tuple enum variants
1 participant