fix(code): add lintlovin and fix linting issues

.editorconfig

@@ -0,0 +1 @@
+node_modules/lintlovin/.editorconfig

.jscsrc

@@ -0,0 +1 @@
+node_modules/lintlovin/.jscsrc

.jshintrc

@@ -0,0 +1 @@
+node_modules/lintlovin/.jshintrc

Gruntfile.js

@@ -0,0 +1,8 @@
+/*jslint node: true */
+'use strict';
+
+var lintlovin = require('lintlovin');
+
+module.exports = function (grunt) {
+  lintlovin.initConfig(grunt);
+};

api.js

@@ -12,11 +12,8 @@ var API = module.exports = {};
 var fs       = require('fs');
 var path     = require('path');
 var jstream  = require('JSONStream');
-var _        = require('lodash');
-var md5      = require('MD5');
-var comments = require('./lib/commentstream');
+var Comments = require('./lib/commentstream');
 var xss      = require('./lib/xss');
-var uglify   = require('uglifyjs');
 
 //
 // ## JavaScript
@@ -96,6 +93,7 @@ API.post = function postComment(request, reply) {
   }
 
   function doneFiltering(err) {
+    console.log(err);
     //if (err) {
     //  var response = reply({
     //    success: false,
@@ -155,10 +153,9 @@ API.get = function getComments(request, reply) {
   // https://github.com/hapijs/hapi/issues/2368
   // Or in JSONStream...
   responseStream._readableState = {};
-  var commentStream  = new comments();
+  var commentStream  = new Comments();
   stream.pipe(commentStream).pipe(responseStream);
 
-  var response = reply(responseStream)
+  reply(responseStream)
     .type('application/json');
 };
-

lib/commentstream.js

@@ -27,5 +27,3 @@ CommentStream.prototype._transform = function _transform(chunk, encoding, done)
   this.push(chunk);
   done();
 };
-
-

lib/socket.js

@@ -37,7 +37,7 @@ SocketManager.prototype.connection = function connection(client) {
 SocketManager.prototype.close = function close(connection) {
   for (var i in this.channels) {
     var index = this.channels[i].indexOf(connection);
-    if (index != -1) {
+    if (index !== -1) {
       this.channels[i].splice(index, 1);
       if (this.channels[i].length === 0) {
         delete(this.channels[i]);
@@ -85,7 +85,9 @@ SocketManager.prototype.subscribe = function subscribe(channel, connection) {
 //
 SocketManager.prototype.dbListener = function (key, value) {
   var channel = this.channels[key.split('~')[0]];
-  if (!channel) return;
+  if (!channel) {
+    return;
+  }
 
   var i = channel.length - 1;
   for (i; i >= 0; i--) {
@@ -95,4 +97,3 @@ SocketManager.prototype.dbListener = function (key, value) {
     client.send(JSON.stringify(value));
   }
 };
-

lib/spam.js

@@ -40,11 +40,9 @@ module.exports.register = function (plugin, options, next) {
       if (err) {
         resp.message = 'Failed to save comment.';
         console.log(err);
-      }
-      else if (isSpam) {
+      } else if (isSpam) {
         resp.message = 'Comment rejected.';
-      }
-      else {
+      } else {
         code = 200;
         resp.success = true;
         resp.message = 'ya';

lib/xss.js

@@ -74,4 +74,3 @@ module.exports = function filter(html, options, callback) {
 module.exports.defaultWhitelist = ['a', 'p', 'strong', 'em', 'b', 'i'];
 module.exports.attributeOK      = ['href'];
 module.exports.noFollowLinks    = true;
-

package.json

@@ -6,7 +6,9 @@
   "homepage": "https://github.com/simme/node-tala",
   "scripts": {
     "start": "node tala.js",
-    "test": "echo \"Error: no test specified\" && exit 1"
+    "test": "node -e \"require('grunt').tasks(['test']);\"",
+    "test-all": "node -e \"require('grunt').tasks(['test-all']);\"",
+    "prepush": "npm test"
   },
   "keywords": [
     "comments",
@@ -28,5 +30,12 @@
     "nodemailer": "~0.6.0",
     "uglifyjs": "^2.4.10",
     "ws": "~0.4.31"
+  },
+  "devDependencies": {
+    "grunt": "^0.4.5",
+    "husky": "^0.7.0",
+    "istanbul": "^0.3.13",
+    "lintlovin": "^1.15.1",
+    "mocha": "^2.2.4"
   }
-}
+}

tala.js

@@ -9,9 +9,8 @@ var hapi     = require('hapi');
 var levelup  = require('levelup');
 var path     = require('path');
 var _        = require('lodash');
-var ws       = require('ws');
 var api      = require('./api');
-var sm       = require('./lib/socket');
+var SocketManager = require('./lib/socket');
 var joi      = require('joi');
 
 //
@@ -63,17 +62,17 @@ function startServer() {
       config: {
         cache: {
           privacy: 'public',
-          //expiresIn: 24 * 3600 * 1000
+          expiresIn: 24 * 3600 * 1000
         },
-        cors: true
+        cors: cors
       }
     },
     {
       path: '/comment',
       method: 'POST',
       handler: api.post,
       config: {
-        cors: true,
+        cors: cors,
         payload: {
           output: 'data',
           parse: true
@@ -83,7 +82,7 @@ function startServer() {
           payload: {
             username: joi.string().min(1).max(32),
             email: joi.string().email(),
-            comment: joi.string().min(1).max(1024*3),
+            comment: joi.string().min(1).max(1024 * 3),
             resource: joi.string().min(1),
             url: joi.string() // @FIXME: Validate URL
           }
@@ -95,7 +94,7 @@ function startServer() {
       method: 'GET',
       handler: api.get,
       config: {
-        cors: { origin: ['*'] }
+        cors: cors
       }
     }
   ]);
@@ -129,5 +128,6 @@ function startServer() {
     });
   });
 
-  var socketManager = new sm(server.listener, db);
+  /* jshint nonew: false */
+  new SocketManager(server.listener, db);
 }

test/tests.txt

@@ -212,4 +212,3 @@ tt	p://6	6.000146.0x7.147/">XSS</A>
 <A HREF="javascript:document.location='http://www.google.com/'">XSS</A>
 
 <A HREF="http://www.gohttp://www.google.com/ogle.com/">XSS</A>
-

test/xss.js

@@ -1,8 +1,11 @@
+/* globals suite, test */
+/* jshint node: true */
+'use strict';
 var assert = require('assert');
 var xss    = require('./../lib/xss');
 
 // Attack vectors copied from https://www.owasp.org/index.php/XSS_Filter_Evasion_Cheat_Sheet
-var vectors = require('fs').readFileSync(__dirname + '/tests.txt', 'utf8');
+//var vectors = require('fs').readFileSync(__dirname + '/tests.txt', 'utf8');
 
 suite('XSS', function () {
   test('Correctly removes non whitelisted tags.', function (done) {
@@ -34,4 +37,3 @@ suite('XSS', function () {
   //  t(parts[0], parts[1], done);
   //});
 });
-