Radioactive Detection Implemented #235
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thanks a lot for taking the time to contribute. Alpha/gamma/beta radiation can be implemented with different 'getCounts()' function (e.g. getAlphaCounts(), getBetaCounts() etc), they also have a different constants for impassable blocks in the path. I've been meaning to implement unit testing for this kind of changes for a while, I'll build some fixture classes that you will be able to use to test the new hardware module. In the meantime I noted some little changes you can work on |
simon987
requested changes
Sep 17, 2020
...n Radioactive Cloud/src/main/java/net/simon987/pluginradioactivecloud/RadiationDetector.java
Outdated
Show resolved
Hide resolved
...n Radioactive Cloud/src/main/java/net/simon987/pluginradioactivecloud/RadiationDetector.java
Outdated
Show resolved
Hide resolved
...n Radioactive Cloud/src/main/java/net/simon987/pluginradioactivecloud/RadiationDetector.java
Outdated
Show resolved
Hide resolved
|
Implemented suggestions and added Beta and Gamma particle functions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I implemented the radioactive detection with alpha particles. I've tested the helper methods separately to make sure they work and the project builds, but I haven't been able to test the handleInterrupt() function in-game. Part of this is due to me still figuring out how to make the cubot move XD.
I know the initial issue stated that there should be beta and gamma radiation, but I'm not sure how all three types of radiation will tie into the game, so I only implemented Alpha Radiation. When/If there is a need for beta and gamma, the code can be written quite easily.
Again, this is a draft PR. If someone can test it in-game before I can and let me know what the correct HW_ID should be, this PR can go into prod.
Let me know your thoughts.
Original Issue #136 .