Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes navigation between word boundaries #348

Merged
merged 5 commits into from
Feb 23, 2024

Conversation

simonbs
Copy link
Owner

@simonbs simonbs commented Feb 23, 2024

This PR fixes an issue where text selection started behaving incorrectly after navigating between word boundaries. The issue could be reproduced using the following steps:

Shift-arrow up a couple lines, then keeping shift down, option-left or option-right to select out a few words, and then try to adjust the selection with right or left arrows. That's where the selection starts happening at origin instead of in the direction of expansion/contraction.

The bug seems to originate from the workaround that ensures multi-stage text input, such as when writing Korean, works properly. The changes in this PR ensures that both multi-stage text input and navigating between word boundaries work correctly.

@simonbs simonbs self-assigned this Feb 23, 2024
@simonbs simonbs merged commit cbc3ae0 into main Feb 23, 2024
9 checks passed
@simonbs simonbs deleted the bugfix/navigation-between-word-boundaries branch February 23, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant