Allow TextLocation to be created #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@migueldeicaza Makes sense to me. I'm happy to merge this once the SwiftLint warning is addressed. I attempted fixing it but it seems that I don't have permission to push to your branch. |
|
Thank you Simon. I think I fixed the issue; I am not sure why this time it did not let you push to my branch. Apologies for that. |
simonbs
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is currently no way of creating a TextLocation from a row, column. Even if that seems to have
been the desire from a previous PR:
#138
This allows me to create TextLocations, which in turn let me gets offsets, which in turn allow me to get screen coordinates from a given position.