Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build with Xcode 16 #375

Merged
merged 1 commit into from
Jun 10, 2024
Merged

Conversation

eliperkins
Copy link
Contributor

Prior to this, Xcode 16 was unable to infer the type of the variable (while Xcode 15 was), so the lookup to reversed() was ambiguous.

This adds String as the inferred type, so that the call to reversed() is no longer ambiguous.

Screenshot 2024-06-10 at 5 38 12 PM

Prior to this, Xcode 16 was unable to infer the type of the variable (while Xcode 15 was), so the lookup to `reversed()` was ambiguous.

This adds `String` as the inferred type, so that the call to `reversed()` is no longer ambiguous.
@eliperkins eliperkins requested a review from simonbs as a code owner June 10, 2024 23:38
@simonbs
Copy link
Owner

simonbs commented Jun 10, 2024

You're fast! Thanks! 🙌

@simonbs simonbs enabled auto-merge (squash) June 10, 2024 23:40
@simonbs simonbs merged commit 1fad339 into simonbs:main Jun 10, 2024
9 checks passed
@eliperkins eliperkins deleted the ep/fix-build-with-xcode-16 branch June 11, 2024 00:09
@eliperkins
Copy link
Contributor Author

If you wanna tag a new version of Runestone, I can bash around on a build from Xcode 16 in the GitHub app too!

@simonbs
Copy link
Owner

simonbs commented Jun 11, 2024

@eliperkins Sure! The change is included in 0.5.1.

migueldeicaza pushed a commit to xibbon/Runestone that referenced this pull request Jun 11, 2024
Prior to this, Xcode 16 was unable to infer the type of the variable (while Xcode 15 was), so the lookup to `reversed()` was ambiguous.

This adds `String` as the inferred type, so that the call to `reversed()` is no longer ambiguous.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants