Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pie chart #1467

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

Pie chart #1467

wants to merge 7 commits into from

Commits on Dec 20, 2023

  1. Add a pie chart (with dummy data) 

    Co-Authored-By: Tom Sydney Kerckhove <[email protected]>
    @raboof @NorfairKing
    raboof and NorfairKing committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    3ac218c View commit details
    Browse the repository at this point in the history

  2. Actually populate the pie chart 

    Co-Authored-By: Tom Sydney Kerckhove <[email protected]>
    @raboof @NorfairKing
    raboof and NorfairKing committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    60ace7b View commit details
    Browse the repository at this point in the history

  3. Show pie chart only if there is more than 1 account

    @raboof
    raboof committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    010ecc0 View commit details
    Browse the repository at this point in the history

  4. Make pie slices clickable

    @raboof
    raboof committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    090c444 View commit details
    Browse the repository at this point in the history

  5. Split into 'positive' and 'negative' pie chart 

    didn't add a label since that would probably just be confusing,
which is which is likely pretty clear from context.
    @raboof
    raboof committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    607090c View commit details
    Browse the repository at this point in the history

  6. Hide chart when more than one commodity present 

    Since the result would be hard to understand anyway
    @raboof
    raboof committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    a32504e View commit details
    Browse the repository at this point in the history

  7. Show pie charts side-by-side, show '100%' charts 

    No charts is shown when there is no data or the data is in multiple
commodities. Perhaps in that case we should show some error and/or
a 'greyed-out' chart?
    @raboof
    raboof committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    1fc9098 View commit details
    Browse the repository at this point in the history