web: RegisterR.getRegisterR.addCommas: do not drop last account #2230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The patch fixes issue #2227. |
thielema
force-pushed
the
web-register-nonempty-comma
branch
from
ee6740a
to
d8fed6e
Compare
Bug was introduced in commit 2a99b3d in an effort to get rid of partial List.tail, because GHC-9.8 started to warn about it. Problem is that the rewritten code with tailDef always removes the last account, whereas the original intention was to replace all accounts by a comma except the last one. addCommas should prepare a comma separated list like List.intercalate.
thielema
force-pushed
the
web-register-nonempty-comma
branch
from
d8fed6e
to
1570680
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug was introduced in commit 2a99b3d in an effort to get rid of partial List.tail,
because GHC-9.8 started to warn about it.
Problem is that the rewritten code with tailDef always removes the last account, whereas the original intention was to replace all accounts by a comma except the last one. addCommas should prepare a comma separated list like List.intercalate.