Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web Balance Report #2242

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

thielema
Copy link
Contributor

@thielema thielema commented Sep 29, 2024

This is a preview for a new feature of hledger-web.
It adds serving balance reports from hledger-web.

So far there remain some issues:

  • I generate HTML with Lucid and then convert to Blaze. Instead I will add a new spreadsheet export backend Write.Html.Blaze. We can later discuss whether we want to keep Lucid, at all.
  • Balance reports are currently integrated in the defaultLayout, which means there is always the sidebar. Do we want that? Of course, the user can hide the sidebar with s key. However, I found the query field useful in conjunction with the balance reports.
  • Links to the balance report are only integrated in the Journal view for now. I could also move them to the query field component. Or above the Journal link in the sidebar.
  • In a further commit I want to add radio buttons for the Layout type, maybe also the format type (TXT, CSV, FODS, HTML), maybe turn the period selection into a radio button, as well.
  • The sidebar link to Journal does not maintain the current query. In the past I did it this way in order to have quick way out of restrictions posed by queries. However, all other accounts in the sidebar in the query and the hyperlinks behind dates in transactions in the Register page also maintain the query. Since I currently have the links to balance reports on the Journal page it would be nice if the top Journal link in the sidebar would also contain the query.

@thielema thielema force-pushed the web-balance-report branch 2 times, most recently from 6536fb2 to 3692f9a Compare September 29, 2024 09:09
@simonmichael
Copy link
Owner

I played around with this. Exciting to see changes in hledger-web, and especially multi-period reports!

This one seems to be a balance changes report, like the balance command's default mode.

With hledger-web I have always been aiming for an easy UI useful to non technical users, that's simple enough to maintain and keep robust. It doesn't look like much but it has had a lot of rough edges smoothed off (some remain..).

It has also probably grown quite a bit of tech debt, and may be hard to extend in big ways without some reorg or even a fresh approach. I haven't focussed on it in some time though.

I am wondering about having an experimental mode, so that we could try out new stuff more freely without creating churn for regular users. Or even a separate binary, hledger-web-x, if needed.

@simonmichael simonmichael added A-WISH Some kind of improvement request, hare-brained proposal, or plea. web The hledger-web tool. labels Sep 29, 2024
@simonmichael
Copy link
Owner

PS shall we change this PR's status to draft.

@thielema thielema marked this pull request as draft September 29, 2024 09:25
@thielema
Copy link
Contributor Author

Yes, I think draft is the right status. However, it seems I cannot change the status myself.

@thielema thielema force-pushed the web-balance-report branch 9 times, most recently from 125bf88 to 80af57a Compare October 3, 2024 16:53
@thielema thielema force-pushed the web-balance-report branch 6 times, most recently from 78474cc to 6fd8f42 Compare October 16, 2024 00:17
@thielema thielema force-pushed the web-balance-report branch 4 times, most recently from 6521c18 to 8390fa4 Compare October 24, 2024 08:54
…od balance reports as HTML pages

Journal page contains links to those reports.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-WISH Some kind of improvement request, hare-brained proposal, or plea. web The hledger-web tool.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants