remove VERSION env var in system, may lead to side effects

simonmittag · Apr 13, 2022 · 67f4b3f · 67f4b3f
1 parent 2a40f82
commit 67f4b3f
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 6 deletions.
diff --git a/logger.go b/logger.go
@@ -59,11 +59,6 @@ func getHost() string {
 }
 
 func getVersion() string {
-	osv := os.Getenv("VERSION")
-	if len(osv) > 0 {
-		Version = osv
-	}
-
 	log.Debug().Str("version", Version).Msg("version determined")
 	return Version
 }

diff --git a/logger_test.go b/logger_test.go
@@ -8,7 +8,7 @@ import (
 
 func TestServerID(t *testing.T) {
 	os.Setenv("HOSTNAME", "localhost")
-	os.Setenv("VERSION", "v0.0.0")
+	Version = "v0.0.0"
 	initServerID()
 	want := "f47f7b28"
 	if ID != want {