Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test/development portability #319

Merged
merged 5 commits into from
May 11, 2023
Merged

Conversation

cnweaver
Copy link
Contributor

This patch collects changes I needed to make to run the tests locally when developing.

Description

This includes:

  • Adding a set of optional development dependencies (pytest, etc.)
  • Fixing docker image names so that pulls from dockerhub succeed
  • Fixing test failures from calling os.path.join on mock objects

Motivation and Context

Without these changes, I could not run the tests in a clean venv (because testing packages are not installed by default), and when i installed these I got large numbers of test failures.

How Has This Been Tested?

After making these changes, and using the new pip install .[dev] option all tests run and pass.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Copy link
Member

@BrianJKoopman BrianJKoopman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Before merging I'd like to especially clear up the issue I brought up with the changes in the docker-compose file, which might just be a lack of documentation on my part.

tests/docker-compose.yml Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
C. Weaver added 2 commits April 12, 2023 17:59
This change was unsafe, as it would run tests over previously released
code, instead of possibly modified, local code.

This reverts commit f357ad3.
@BrianJKoopman BrianJKoopman merged commit 0a0404d into simonsobs:main May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants