Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add importlib_metadata dependency for ocs-agent-cli #323

Merged
merged 1 commit into from
Mar 15, 2023

Conversation

BrianJKoopman
Copy link
Member

Description

Adds importlib_metadata as a dependency for python versions below 3.10, as used in ocs-agent-cli.

Motivation and Context

Ran into this missing dependency on an older system with Python 3.8.

How Has This Been Tested?

Installed in a clean python3.8 and python 3.10 environment to check the python version dependent install, and ran ocs-agent-cli to confirm missing module error went away.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@BrianJKoopman BrianJKoopman merged commit 91c51d5 into main Mar 15, 2023
@BrianJKoopman BrianJKoopman deleted the koopman/importlib-metadata-dep branch March 15, 2023 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant