Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin docutils and add readthedocs config file #209

Merged
merged 2 commits into from
Oct 27, 2021

Conversation

BrianJKoopman
Copy link
Member

@BrianJKoopman BrianJKoopman commented Oct 26, 2021

Description

A recent update in docutils breaks builds on readthedocs. This is the suggested
work around from [1].

[1] - readthedocs/readthedocs.org#8616

Motivation and Context

A fresh build of the docs on the develop branch fails: https://readthedocs.org/projects/socs/builds/15099682/

How Has This Been Tested?

This PR will test the build in the checks below.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • Unless I am preparing a release, I have opened this PR onto the develop branch.

@BrianJKoopman BrianJKoopman added the bug Something isn't working label Oct 26, 2021
@BrianJKoopman
Copy link
Member Author

Probably we should be pinning a bit more than just docutils, or specifying a more recent version of sphinx. I'm going to check that out a bit more before merging this. Converting to draft for now.

https://docs.readthedocs.io/en/stable/guides/reproducible-builds.html#reproducible-builds

@BrianJKoopman BrianJKoopman marked this pull request as draft October 27, 2021 14:35
A recent update in docutils breaks builds on readthedocs. This is the suggested
work around from readthedocs [1].

[1] - readthedocs/readthedocs.org#8616
Also update the documentation on how to build the docs, and explicitly define
the readthedocs config.
@BrianJKoopman BrianJKoopman changed the base branch from develop to koopman/sphinx-html-css-files October 27, 2021 22:12
Base automatically changed from koopman/sphinx-html-css-files to develop October 27, 2021 22:14
@BrianJKoopman BrianJKoopman marked this pull request as ready for review October 27, 2021 22:14
@BrianJKoopman BrianJKoopman merged commit 69cb462 into develop Oct 27, 2021
@BrianJKoopman BrianJKoopman deleted the koopman/docutils-rtd-fix branch October 27, 2021 22:15
BrianJKoopman added a commit to simonsobs/ocs that referenced this pull request Oct 29, 2021
This does exactly what we did to fix the rtd builds over in [1].

[1] - simonsobs/socs#209
@BrianJKoopman BrianJKoopman mentioned this pull request Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant