Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

?_nofacets=1 query string argument for disabling facets and suggested facets #1350

Closed
simonw opened this issue May 31, 2021 · 2 comments
Closed

Comments

@simonw
Copy link
Owner

simonw commented May 31, 2021

This is needed as an internal option for #1349. datasette-graphql can benefit from this too - maybe can even use it so that if you pass ?_shape=array it gets automatically added, fixing #263.

@simonw simonw changed the title _facets_off=1 query string argument for disabling facets and suggested facets ?_facets_off=1 query string argument for disabling facets and suggested facets May 31, 2021
@simonw
Copy link
Owner Author

simonw commented May 31, 2021

I think ?_facets_off=1 is a good design for this.

I considered ?_facet= with an empty string but that's a bit weird, and it's not clear what that would do if used like ?_facet=state&_facet=.

So it definitely needs to be a separate named option.

Actually, since I have ?_nocol= I'm going to call this ?_nofacets=1 instead as that's a little more consistent.

@simonw simonw changed the title ?_facets_off=1 query string argument for disabling facets and suggested facets ?_nofacets=1 query string argument for disabling facets and suggested facets May 31, 2021
@simonw simonw closed this as completed in c5ae119 May 31, 2021
simonw added a commit that referenced this issue Jun 1, 2021
@simonw
Copy link
Owner Author

simonw commented Jun 1, 2021

I renamed this to ?_nofacet=1 in #1353.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant