Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve query on timeout #1819

Closed
danp opened this issue Sep 25, 2022 · 3 comments
Closed

Preserve query on timeout #1819

danp opened this issue Sep 25, 2022 · 3 comments

Comments

@danp
Copy link
Contributor

danp commented Sep 25, 2022

If a query hits the timeout it shows a message like:

SQL query took too long. The time limit is controlled by the sql_time_limit_ms configuration option.

But the query is lost. Hitting the browser back button shows the query before the one that errored.

It would be nice if the query that errored was preserved for more tweaking. This would make it similar to how "invalid syntax" works since #1346 / #619.

@simonw
Copy link
Owner

simonw commented Sep 26, 2022

This is a good idea.

@simonw
Copy link
Owner

simonw commented Sep 26, 2022

Implementing it like this, so at least you can copy and paste the SQL query back out again:

image

I'm not doing a full textarea because this error can be raised in multiple places, including on the table page itself. It's not just an error associated with the manual query page.

@simonw simonw closed this as completed in 5f9f567 Sep 26, 2022
simonw added a commit that referenced this issue Oct 24, 2022
@simonw simonw mentioned this issue Oct 27, 2022
simonw added a commit that referenced this issue Oct 27, 2022
simonw added a commit that referenced this issue Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants