feat: Adds support for custom keyboard pages and other customizations #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hi 👋🏽 Thank you for opening your first PR with simpleclub/math_keyboard ❤
You can expect a review from us soon
In the meantime, please check our contribution guidelines, the PR checklist, and the PR checks.
edhom
requested changes
Oct 5, 2023
There was a problem hiding this comment.
@Sub6Resources Thanks Matthew for the contribution😍 And sorry for the late review! I have just some nits but happy to merge this one then:)
| /// The buttons to display. | ||
| final List<List<KeyboardButtonConfig>>? page2; | ||
| /// The configuration for all the pages on the keyboard. | ||
| final List<CustomButtonPage>? pages; |
There was a problem hiding this comment.
Suggested change
| final List<CustomButtonPage>? pages; | |
| final List<CustomButtonPage> pages; |
I think this can't be nullable anymore
Comment on lines
+144
to
+148
| else if (type == | ||
| MathKeyboardType.expression) | ||
| standardKeyboard, | ||
| if (type == MathKeyboardType.expression) | ||
| functionKeyboard, |
There was a problem hiding this comment.
Suggested change
| else if (type == | |
| MathKeyboardType.expression) | |
| standardKeyboard, | |
| if (type == MathKeyboardType.expression) | |
| functionKeyboard, | |
| if (type == MathKeyboardType.expression) | |
| standardKeyboard, | |
| functionKeyboard, |
Comment on lines
+399
to
+404
| ...(widget.customPages.fold<List<List<KeyboardButtonConfig>>>( | ||
| [], | ||
| (previousValue, customPage) { | ||
| return previousValue..addAll(customPage.buttonLayout); | ||
| }, | ||
| )), |
There was a problem hiding this comment.
Suggested change
| ...(widget.customPages.fold<List<List<KeyboardButtonConfig>>>( | |
| [], | |
| (previousValue, customPage) { | |
| return previousValue..addAll(customPage.buttonLayout); | |
| }, | |
| )), | |
| for (final page in widget.customPages) | |
| ...page.buttonLayout |
Could you check if this works?🙂
|
@Sub6Resources @edhom this is a very useful PR can it be merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
bool secondPagehas been replaced withint pageinMathFieldEditingControllerto allow for more than two pages.customPagesattribute that takes a list ofCustomButtonPages.CustomButtonPagetakes aList<List<KeyboardButtonConfig>>as well as an optionallabeloriconto be shown using thePageButtonConfig.fontSizeattribute toMathKeyboardand akeyboardButtonFontSizeattribute toMathFieldto allow the font size of the keyboard buttons to be adjusted.heightFactorattribute toKeyboardButtonConfigto allow for customization of the height of keyboard rows.MathKeyboardto test the functionality of custom and default pages on the keyboard.Related issues & PRs
None
Checklist
contributing guide.
math_keyboardorexamplepackage(also README etc.), I created an entry in
CHANGELOG.md(## UPCOMING RELEASEif the changeon its own is not worth an update).
math_keyboardpackage, I updated the versionaccording to Dart's semantic versioning.