Reduce gem package size by excluding assets directory #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this code has been taken from the bundler newgem template https://github.com/rubygems/rubygems/blob/master/bundler/lib/bundler/templates/newgem/newgem.gemspec.tt
especially, js files under assets dir are very huge, but used only for precompiling assets, and not referenced in production.
sferik
approved these changes
Dec 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gem package size of this gem is significantly becoming larger in recent versions.
This seems to be caused via 0eccc9c which adds a new js library and starts bundling non-minified version of jQuery. That commit at the same time introduces assets compression, and hence that change didn't really impact the actual runtime performance, but resulted in gem package size growth.
However, since asset files under
assetsdirectory are used only during precompilation phase and not referenced in users' side, the whole directory can be safely omitted from the gem package.This patch removes some "development only" files including the
assetsdirectory. Result of the installed gem size is as follows: