Bring Ruby 2.5 and 2.6 support back #1108
Merged
+60
−52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before working on the next release, I'd like to revert some changes that just bumped the supported Ruby versions with no good reason.
a2750f5 made it possible to run the CI against older Rubies that were supported on the previous gem versioned 0.22.0. And now that the CI seems to be healthily working with all these Rubies, I don't see any good reason not to just keep them working.
I'm happy to bump minimum version to 2.7 or whatever if there's any benefit, for instance once we start depending on any useful Ruby 2.7 feature, but until then, let's just maintain what we already have.