Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance: memomize LinesClassifier::no_cov_line #662

Merged
merged 1 commit into from
Mar 10, 2018

Commits on Mar 9, 2018

  1. Performance: memomize LinesClassifier::no_cov_line

    In my measurements the majority of the time in SimpleCov was being
    spent in this one-line function.
    
    In my tests on a large project, this change makes SimpleCov run
    from 2.5x to 3.75x faster.
    
    Admittedly, memoizing it does change its behavior but only in the edge
    case where someone runs SimpleCov twice in a single test run, changing
    the +nocov_token+ between the two runs. This is such an odd edge case I
    decided not to worry about it.
    BMorearty committed Mar 9, 2018
    Configuration menu
    Copy the full SHA
    93b82b2 View commit details
    Browse the repository at this point in the history