Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @runger1101001 and @askuric,
Hope this is the right way to contribute.
This is what I proposed here.
Before the change:
RAM: [= ] 9.2% (used 4536 bytes from 49152 bytes)
Flash: [=== ] 27.1% (used 71076 bytes from 262144 bytes)
loopfoc takes up to 220us with SVPWM
After the change:
RAM: [= ] 9.2% (used 4536 bytes from 49152 bytes)
Flash: [=== ] 26.6% (used 69676 bytes from 262144 bytes)
loopfoc takes up to 156us with SVPWM
loopfoc takes up to 152us with SinePWM
I only saw a very small difference in magnitude between the old and new SVPWM without center modulation.
With center modulation it's exactly the same.
I decide to just add SVPWM to the SinePWM code and not duplicate all the code.