Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/regtest address #1

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Feature/regtest address #1

wants to merge 10 commits into from

Conversation

SuperCipher
Copy link

add regtest support

naach added 9 commits September 17, 2020 09:25
feat(regtest support): add regtest capability
df683dc
fix(toCashAddress):
6848242 
should translate legacy address format to cashaddr format correctly
test(bcgreg):
3071020 
add regtest address test case
chore: deploy npm package
5fc7d56
add yarn lock file
3d8c9c2
feature(toSlpAddress):
85387ae 
regtest address support
test(bchreg):
dff1fdf 
add slp regtest address
chore: bump npm version
fa224c9
Merge branch 'master' of github.com:simpleledger/bchaddrjs into featu…
00fa519 
…re/regtest-address

* 'master' of github.com:simpleledger/bchaddrjs:
  d.ts update
  add d.ts file
@jcramer jcramer self-requested a review December 14, 2020 14:18
@jcramer
Copy link

jcramer commented Dec 14, 2020

Thanks for submitting the PR.

I don't understand why we need to add the "regtest" parameter in many of the methods. I use this library with the regtest network as-is.

For example:

https://github.com/simpleledgerinc/cpp_slp_graph_search/blob/766da4714524a57ba260f179556961eef30d11cb/regtest-bchn/test/helpers/rpcwallet.ts#L64

Can you please explain why these changes are needed and what can't be achieved as-is?

@SuperCipher SuperCipher mentioned this pull request Feb 23, 2021
Open
@SuperCipher
Copy link
Author

@jcramer Because many methods requires regtest flag to discern between regtest and testnet address
e.g. decodeAddress function won't be able to recognize the difference between regtest and testnet address because they have the same version byte.
df683dc#diff-fc46f429a15c48e36f14a8c98ee2897d741be553acaf266d17ec4c915caabd14R172

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcramer jcramer Awaiting requested review from jcramer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SuperCipher @jcramer @nexerino