Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PartitionedFile.filePath handling for spark 3.5.0 #114

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix PartitionedFile.filePath handling for spark 3.5.0 #114

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ lazy val commonIOVersion = "2.5"
lazy val logbackVersion = "1.1.7"
lazy val scoptVersion = "3.7.1"
lazy val akkaVersion = "2.5.31"
lazy val spark3Version = "3.1.1"
lazy val spark3Version = "3.5.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this change break compatibility with Spark 3.2 and 3.1?
At the moment, I can not expend time doing the testing (basically, I'm focused on looking for a new contract. If you know one, let me know. 😉 )

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will do some testing with spark 3.3, 3.2, 3.1 and will let you know about the result.
If I see an interesting project, I will let you know.

Copy link

@jensgoossens-tomtom jensgoossens-tomtom Dec 4, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any progress on this? You could keep the version on 3.1.1 and just call toString anyway - for people using Spark 3.4+ it will call toString() on the SparkPath returned - for people using older versions nothing will change?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually the fix is not working for older versions.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to increase the version, and release it for Spark 3.5?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jensgoossens-tomtom @alexeisolodovnicov-tomtom Maybe your company is able to support this project. That would give me a little bit of energy and motivation. Even one beer would be enough. ;)

I'm open to any type of collaboration. Are they looking for Solution Architects?

https://github.com/sponsors/simplexspatial

lazy val spark2Version = "2.4.7"
lazy val sparkDefaultVersion = spark3Version

Expand Down
2 changes: 1 addition & 1 deletion spark/src/main/scala/com/acervera/osm4scala/spark/OsmPbfFormat.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ class OsmPbfFormat extends FileFormat with DataSourceRegister {

(file: PartitionedFile) =>
{
val path = new Path(new URI(file.filePath))
val path = new Path(new URI(file.filePath.toString))
val fs = path.getFileSystem(broadcastedHadoopConf.value.value)
val status = fs.getFileStatus(path)

Expand Down
Loading